Just before Brexit (we lived in Spain, and I thought it would be useful to have), I applied for an Irish passport, and I'm pleased and proud that through my parents, my son and my daughter now have Irish passports as well.
Having an Irish passport has been a great help to my son, who has lived and worked in Norway for the last 4 years.
It's very important, though, to make sure you always renew your British passport, particularly if and when you return to the UK to live, as we did after 17 fab years of living in Mallorca.